[#35] add logging, fix exception messages when failed to load functio…

…ns or parse arguments

custom_components/extended_openai_conversation/__init__.py

@@ -56,6 +56,8 @@
     CallServiceError,
     FunctionNotFound,
     NativeNotFound,
+    FunctionLoadFailed,
+    ParseArgumentsFailed,
 )
 
 from .helpers import (
@@ -171,14 +173,8 @@ async def async_process(
             return conversation.ConversationResult(
                 response=intent_response, conversation_id=conversation_id
             )
-        except (
-            EntityNotFound,
-            ServiceNotFound,
-            CallServiceError,
-            EntityNotExposed,
-            FunctionNotFound,
-            NativeNotFound,
-        ) as err:
+        except HomeAssistantError as err:
+            _LOGGER.error(err, exc_info=err)
             intent_response = intent.IntentResponse(language=user_input.language)
             intent_response.async_set_error(
                 intent.IntentResponseErrorCode.UNKNOWN,
@@ -242,9 +238,8 @@ def get_functions(self):
                     for function in setting["function"].values():
                         convert_to_template(function, hass=self.hass)
             return result
-        except Exception as e:
-            _LOGGER.error("Failed to load functions", e)
-            return []
+        except:
+            raise FunctionLoadFailed()
 
     async def query(
         self,
@@ -323,7 +318,10 @@ async def execute_function(
         function,
     ):
         function_executor = FUNCTION_EXECUTORS[function["function"]["type"]]
-        arguments = json.loads(message["function_call"]["arguments"])
+        try:
+            arguments = json.loads(message["function_call"]["arguments"])
+        except json.decoder.JSONDecodeError:
+            raise ParseArgumentsFailed(message["function_call"]["arguments"])
 
         result = await function_executor.execute(
             self.hass, function["function"], arguments, user_input, exposed_entities

custom_components/extended_openai_conversation/exceptions.py

@@ -70,3 +70,34 @@ def __init__(self, name: str) -> None:
     def __str__(self) -> str:
         """Return string representation."""
         return f"native function '{self.name}' does not exist"
+
+
+class FunctionLoadFailed(HomeAssistantError):
+    """When function load failed."""
+
+    def __init__(self) -> None:
+        """Initialize error."""
+        super().__init__(
+            self,
+            "failed to load functions. Verify functions are valid in a yaml format",
+        )
+
+    def __str__(self) -> str:
+        """Return string representation."""
+        return "failed to load functions. Verify functions are valid in a yaml format"
+
+
+class ParseArgumentsFailed(HomeAssistantError):
+    """When parse arguments failed."""
+
+    def __init__(self, arguments: str) -> None:
+        """Initialize error."""
+        super().__init__(
+            self,
+            f"failed to parse arguments `{arguments}`. Increase maximum token to avoid the issue.",
+        )
+        self.arguments = arguments
+
+    def __str__(self) -> str:
+        """Return string representation."""
+        return f"failed to parse arguments `{self.arguments}`. Increase maximum token to avoid the issue."

custom_components/extended_openai_conversation/helpers.py

@@ -486,8 +486,9 @@ async def execute(
 
         q = Template(query, hass).async_render(template_arguments)
         _LOGGER.info("Rendered query: %s", q)
+
         with sqlite3.connect(db_url, uri=True) as conn:
-            cursor = conn.execute(q)
+            cursor = conn.cursor().execute(q)
             names = [description[0] for description in cursor.description]
 
             if function.get("single") is True: