Add update_resource action to metricstransform #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferbrecht
changed the title
Small refactor to more easily allow us to provide an `update_resource` action that can chain with other transforms. This passes the existing tests but I need to add some more coverage before I can be confident that this is a non-breaking change. One caveat with this is that I'm buffering the whole slice of ResourceMetrics up front. Not sure of the performance implications.
jefferbrecht
force-pushed
the
jefferbrecht-update-resource
branch
from
75e0718
to
51d51a9
Compare
|
Upstream already merged a feature which obsoletes this PR: open-telemetry#9719 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.