fix: Ensure dependencies are available for alternative backends #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid
changed the title
|
I believe this has caused a failure in e2e/backend/test_go_install_slow (which doesn't run on PRs), currently investigating why |
|
Looks like that release branch was failing before this was merged (based on this CI run), which makes me think it's #2524 instead. The test uses a symlink and that changed how symlinks are handled across a number of operations. Like I said, I wasn't able to get the e2e tests running locally using docker (mise wouldn't compile; |
|
yep you are correct, verified via bisect |
triarius
pushed a commit
to triarius/mise
that referenced
this pull request
Sep 18, 2024
…2532) * ensure dependencies are loaded for experimental backends * fix cargo-binstall * fix test * simplicy e2e test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing a tool via one of the experimental backends (
npm,pipx, etc), the install would fail if the backend was managed bymiseitself.When setting up the paths for the installation command (
npm install tldr) to run,misewasn't making the backends specified inget_dependenciesavailable to the subshell. So, they'd fail with a cryptic error:This was because
npmwasn't in the path, despite it being installed.I restructured some existing code to make creating a Toolset for a backend's dependents simple, then prepended those paths to the resulting command. I've confirmed locally that installations commands that fail without the
I also added a line to an e2e test, but I wasn't able to get those running locally in docker, so it's worth double checking that works as intended before merge.
fixes #2174
fixes #2315
fixes #2457
fixes #2458