fix: mise use does not create a local .mise.toml anymore #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roele
force-pushed
the
issues/2405
branch
3 times, most recently
from
acb9a06
to
f41a5f9
Compare
|
After looking at the failing tests i wonder how config file creation is supposed to work. How do we know if a tool-version file should be created? Use the asdf_compat setting? Also unit tests fail because of an OpenSSL vulnerability which should be fixed with #2397 |
roele
commented
Jul 28, 2024
| fn test_use_local_tool_versions() { | ||
| fn test_use_local_create() { | ||
| reset(); | ||
| let _ = file::remove_file(env::current_dir().unwrap().join(".test-tool-versions")); |
There was a problem hiding this comment.
we have to explicitly remove the .test-tool-versions as the test setup creates both
This was referenced Jul 29, 2024
triarius
pushed a commit
to triarius/mise
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2405
Not quite sure if this is the correct approach. The
LOCAL_CONFIG_FILENAMESis very extensive and also contains the path of the global configuration file. So traversing up directories from a directory within user home will at some point find the global configuration. Am i assuming correctly that you could also have the path.config/mise/config.tomlin a specific project directory?