Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backend install directory not removed if empty #2018

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

roele
Copy link
Contributor

@roele roele commented May 2, 2024

Adds some new functions to remove a directory passing in a list of files to ignore for the empty dir check. This allows to remove the (empty) backend directory despite the new hidden .mise.forge.json file.

Fixes #2017

@jdx jdx enabled auto-merge (squash) May 2, 2024 17:14
auto-merge was automatically disabled May 2, 2024 17:31

Head branch was pushed to by a user without write access

@roele
Copy link
Contributor Author

roele commented May 2, 2024

Have experienced some flakiness in the unit tests, even locally they seemed to fail somewhat randomly 🤔

Following was failing ~50% of the time... Don't see how this is related to these changes, maybe it's not.

failures:

---- cli::env::tests::test_env_tiny stdout ----
thread 'cli::env::tests::test_env_tiny' panicked at src/cli/env.rs:117:9:
assertion failed: `(left == right)`

Diff < left / right > :
<export JDXCODE_TINY=1.0.1
>export JDXCODE_TINY=2.1.0


note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    cli::env::tests::test_env_tiny

test result: FAILED. 218 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 5.10s

@jdx jdx merged commit 991fcdb into jdx:main May 3, 2024
6 checks passed
@jdx
Copy link
Owner

jdx commented May 3, 2024

Hmm, doesn't look related, I'll check it out tomorrow

@roele roele deleted the issues/2017 branch May 3, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backend install directory not removed if empty
2 participants