Skip to content

Commit

Permalink
fix: clean up architectures for precompiled binaries
Browse files Browse the repository at this point in the history
Most of these were incorrect and showing warnings on nightly
  • Loading branch information
jdx committed May 19, 2024
1 parent 70d4e92 commit cb65bf3
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 33 deletions.
4 changes: 1 addition & 3 deletions src/plugins/core/bun.rs
Original file line number Diff line number Diff line change
Expand Up @@ -133,14 +133,12 @@ fn os() -> &'static str {
}

fn arch() -> &'static str {
if cfg!(target_arch = "x86_64") || cfg!(target_arch = "amd64") {
if cfg!(target_arch = "x86_64") {
if cfg!(target_feature = "avx2") {
"x64"
} else {
"x64-baseline"
}
} else if cfg!(target_arch = "aarch64") || cfg!(target_arch = "arm64") {
"aarch64"
} else {
&ARCH
}
Expand Down
8 changes: 1 addition & 7 deletions src/plugins/core/deno.rs
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,5 @@ fn os() -> &'static str {
}

fn arch() -> &'static str {
if cfg!(target_arch = "x86_64") || cfg!(target_arch = "amd64") {
"x86_64"
} else if cfg!(target_arch = "aarch64") || cfg!(target_arch = "arm64") {
"aarch64"
} else {
&ARCH
}
&ARCH
}
9 changes: 3 additions & 6 deletions src/plugins/core/go.rs
Original file line number Diff line number Diff line change
Expand Up @@ -252,14 +252,11 @@ fn platform() -> &'static str {
}

fn arch() -> &'static str {
if cfg!(target_arch = "x86_64") || cfg!(target_arch = "amd64") {
if cfg!(target_arch = "x86_64") {
"amd64"
} else if cfg!(target_arch = "i686") || cfg!(target_arch = "i386") || cfg!(target_arch = "386")
{
"386"
} else if cfg!(target_arch = "armv6l") || cfg!(target_arch = "armv7l") {
} else if cfg!(target_arch = "arm") {
"armv6l"
} else if cfg!(target_arch = "aarch64") || cfg!(target_arch = "arm64") {
} else if cfg!(target_arch = "aarch64") {
"arm64"
} else {
&ARCH
Expand Down
6 changes: 1 addition & 5 deletions src/plugins/core/java.rs
Original file line number Diff line number Diff line change
Expand Up @@ -400,12 +400,8 @@ fn os() -> &'static str {
}

fn arch() -> &'static str {
if cfg!(target_arch = "x86_64") || cfg!(target_arch = "amd64") {
"x86_64"
} else if cfg!(target_arch = "armv6l") || cfg!(target_arch = "armv7l") {
if cfg!(target_arch = "arm") {
"arm32-vfp-hflt"
} else if cfg!(target_arch = "aarch64") || cfg!(target_arch = "arm64") {
"aarch64"
} else {
&ARCH
}
Expand Down
4 changes: 1 addition & 3 deletions src/plugins/core/node.rs
Original file line number Diff line number Diff line change
Expand Up @@ -400,9 +400,7 @@ fn os() -> &'static str {
}

fn arch() -> &'static str {
if cfg!(target_arch = "x86") {
"x86"
} else if cfg!(target_arch = "x86_64") {
if cfg!(target_arch = "x86_64") {
"x64"
} else if cfg!(target_arch = "arm") {
"armv7l"
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/core/python.rs
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ fn python_arch(settings: &Settings) -> &str {
if let Some(arch) = &settings.python_precompiled_arch {
return arch.as_str();
}
if cfg!(all(os = "linux", target_arch = "x86_64")) {
if cfg!(all(target_os = "linux", target_arch = "x86_64")) {
if cfg!(target_feature = "avx512f") {
"x86_64_v4"
} else if cfg!(target_feature = "avx2") {
Expand Down
9 changes: 1 addition & 8 deletions src/plugins/core/zig.rs
Original file line number Diff line number Diff line change
Expand Up @@ -163,14 +163,7 @@ fn os() -> &'static str {
}

fn arch() -> &'static str {
if cfg!(target_arch = "x86_64") || cfg!(target_arch = "amd64") {
"x86_64"
} else if cfg!(target_arch = "i686") || cfg!(target_arch = "i386") || cfg!(target_arch = "386")
{
"i386"
} else if cfg!(target_arch = "aarch64") || cfg!(target_arch = "arm64") {
"aarch64"
} else if cfg!(target_arch = "armv7a") {
if cfg!(target_arch = "arm") {
"armv7a"
} else if cfg!(target_arch = "riscv64") {
"riscv64"
Expand Down

0 comments on commit cb65bf3

Please sign in to comment.