Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add givens2 gate #253

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Add givens2 gate #253

merged 2 commits into from
Aug 19, 2024
+41,244 −49,630

Conversation

kevinsung
Copy link
Contributor

Fixes #245

kevinsung
kevinsung commented Aug 18, 2024
View reviewed changes
tests/test_tensor/test_circuit.py
@@ -269,7 +269,8 @@ def test_all_gate_methods(self, Circ):
("cu1", 2, 1),
("fsim", 2, 2),
("fsimg", 2, 5),
("rzz", 2, 1),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rzz is already tested above

@kevinsung kevinsung force-pushed the givens2 branch 2 times, most recently from e3f5b7d to af1073a Compare August 18, 2024 23:38
@kevinsung
Copy link
Contributor Author

Rerunning the notebook that lists gates produced a huge diff. Is there a recommended way to keep the diff small?

FYI there is a tool squeaky, that helps format Jupyter notebooks to keep the diffs small in situations like these.

@jcmgray
Copy link
Owner

jcmgray commented Aug 19, 2024

All looks good to me! Thanks very much.

Rerunning the notebook that lists gates produced a huge diff. Is there a recommended way to keep the diff small?
FYI there is a tool squeaky, that helps format Jupyter notebooks to keep the diffs small in situations like these.

Thanks for pointing out squeaky, I will check it out for future use. Currently yes I tend to just view the diffs with vscode.

@jcmgray jcmgray merged commit e067d2a into jcmgray:main Aug 19, 2024
34 checks passed
@kevinsung kevinsung deleted the givens2 branch August 19, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add complex Givens rotation
2 participants
@kevinsung @jcmgray