Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C/C++ domain support for :node-id: and :symbol-ids: #379

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

jbms
Copy link
Owner

@jbms jbms commented Aug 2, 2024

Previously, these were not properly taken into account by parameter objects.

Previously, these were not properly taken into account by parameter
objects.
@jbms jbms requested a review from 2bndy5 August 2, 2024 23:06
@jbms
Copy link
Owner Author

jbms commented Aug 2, 2024

This commit was actually sitting in my local repo for 18 months --- I had forgotten about it.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.19%. Comparing base (9ec088e) to head (c87f044).

Files Patch % Lines
sphinx_immaterial/apidoc/cpp/symbol_ids.py 85.18% 4 Missing ⚠️
sphinx_immaterial/apidoc/cpp/parameter_objects.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
+ Coverage   67.19%   71.19%   +4.00%     
==========================================
  Files          68       68              
  Lines        8515     8545      +30     
==========================================
+ Hits         5722     6084     +362     
+ Misses       2793     2461     -332     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the last 18 months, I've switched out my primary drive for a new one (with bigger capacity) and had to reinstall Windows (and Ubuntu on my old drive). Any local changes I had (including corrupt indexes) would have been wiped out.

I'm pretty good at cleaning up branches (on the remote) that have been merged, so feel free to push any local WIP branches in the future.


In another project, I was re-basing a feature branch for almost 2 years until I found/fixed the bug preventing the PR.

@jbms jbms merged commit c05be47 into main Aug 3, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants