Various fixes to C++ domain and format_signatures #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For unknown reasons, in some cases libclang fails to include doc comments in the `Cursor.raw_comment` field when they are present. As a workaround, don't rely on the `Cursor.raw_comment` field and instead parse doc comments from the surrounding tokens directly. This also makes the parsing of the raw comment into doc comments handle the case of mixed doc comment types.
libclang seems to generate UNEXPOSED_DECL cursors for instantiations (not specializations) of variable templates in certain cases/with certain versions of libclang. These cursors result in a JSON entity description that is identical that produced from the cursor corresponding to the original definition. These are now excluded as duplicates based on the assumption that they will occur after the "real" cursor.
When aligning the pre-formatted and post-formatted text, ignore whitespace for better alignment.
Previously, the cppreference data and the json schema data were stored on the `env` object. Data on the `env` object is pickled and sent back separately with every chunk of documents that are processed by a worker process. Only information that relates to the specific documents that have been read should be stored on the `env` object.
Previously, unnamed template parameters were incorrectly assigned a name of `"None"`.
|
This PR combines a number of independent fixes. Please refer to the independent commit descriptions for details. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
+ Coverage 67.19% 76.07% +8.87%
==========================================
Files 68 68
Lines 8515 8598 +83
==========================================
+ Hits 5722 6541 +819
+ Misses 2793 2057 -736 ☔ View full report in Codecov by Sentry. |
2bndy5
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:any:xrefs to C macros