Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json: Fix bug with specifying maxItems but not minItems #371

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

jbms
Copy link
Owner

@jbms jbms commented Jul 22, 2024

Previously, this would incorrectly lead to an exception being thrown.

Previously, this would incorrectly lead to an exception being thrown.
@jbms jbms requested a review from 2bndy5 July 22, 2024 21:31
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.09%. Comparing base (7e2d559) to head (368b814).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
+ Coverage   63.00%   63.09%   +0.08%     
==========================================
  Files          68       68              
  Lines        8502     8502              
==========================================
+ Hits         5357     5364       +7     
+ Misses       3145     3138       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbms jbms merged commit f5e3d7c into main Jul 23, 2024
62 checks passed
@jbms jbms deleted the fix-json-schema-min-items branch July 23, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants