Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate colon from headings in field lists #157

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Eliminate colon from headings in field lists #157

merged 1 commit into from
Aug 31, 2022

Conversation

jbms
Copy link
Owner

@jbms jbms commented Aug 31, 2022

Fixes #156.

This also refactors the various HTMLTranslator overrides.

@jbms jbms requested a review from 2bndy5 August 31, 2022 00:49
@jbms
Eliminate colon from headings in field lists
c6f3b3d 
Fixes #156.

This also refactors the various HTMLTranslator overrides.
@jbms jbms merged commit 23cd5b7 into main Aug 31, 2022
@jbms jbms deleted the fix-156 branch August 31, 2022 02:54
@2bndy5 2bndy5 mentioned this pull request Aug 31, 2022
Closed
mhostetter
mhostetter reviewed Aug 31, 2022
View reviewed changes
sphinx_immaterial/apidoc/object_toc.py
app, "include_fields_in_toc", type_constraint=bool, default=True
)
object_description_options.add_object_description_option(
app, "include_rubrics_in_toc", type_constraint=bool, default=True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an observation... include_rubrics_in_toc used to default to False. I'm fine with it being default True, but just making you aware in case that was unintentional.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that was not intended, fixed in #160.

@jbms jbms mentioned this pull request Aug 31, 2022
Closed
2bndy5 added a commit that referenced this pull request Apr 30, 2023
@2bndy5
remove unnecessary permalink to depart_term()
11c4f68 
resolves #248

The problem doesn't seem instigated by any changes to docutils or sphinx.
So, it may have been something that was originally overlooked in #157.

Use `rst-example` for the `glossary` directive in additional_samples.rst
@2bndy5 2bndy5 mentioned this pull request Apr 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhostetter mhostetter mhostetter left review comments

@2bndy5 2bndy5 2bndy5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fields render differently between RTD and GH Pages
3 participants
@jbms @mhostetter @2bndy5