Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip>=19.1 compatibility #795

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Apr 24, 2019

Closes issue #794.

Changelog-friendly one-liner: Fix pip>=19.1 compatibility

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev changed the title Fix pip>=19.1 compatibility WIP: Fix pip>=19.1 compatibility Apr 24, 2019
@codecov

This comment has been minimized.

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #795 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
+ Coverage   98.06%   98.06%   +<.01%     
==========================================
  Files          34       34              
  Lines        1962     1965       +3     
  Branches      256      257       +1     
==========================================
+ Hits         1924     1927       +3     
  Misses         26       26              
  Partials       12       12
Impacted Files Coverage Δ
piptools/repositories/pypi.py 89.34% <100%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d0a91a...69e8829. Read the comment docs.

@atugushev atugushev added this to the 3.6.1 milestone Apr 24, 2019
@atugushev atugushev added pip Related to pip Bug fix labels Apr 24, 2019
@atugushev atugushev changed the title WIP: Fix pip>=19.1 compatibility Fix pip>=19.1 compatibility Apr 24, 2019
Copy link
Member

@vphilippon vphilippon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks for the quick PR!

I'll get on the release right away.

@vphilippon vphilippon merged commit 73e3505 into jazzband:master Apr 24, 2019
@naggie
Copy link

naggie commented Apr 24, 2019

Thanks for fixing this so fast, @atugushev

@atugushev atugushev deleted the compat-pip-19.1 branch April 24, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pip Related to pip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants