Fix the output file for pip-compile with an explicit setup.py as source file #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atugushev
requested review from
blueyed,
jdufresne,
davidovich and
vphilippon
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
==========================================
+ Coverage 86.33% 86.56% +0.23%
==========================================
Files 34 34
Lines 2129 2137 +8
Branches 303 302 -1
==========================================
+ Hits 1838 1850 +12
+ Misses 226 224 -2
+ Partials 65 63 -2
Continue to review full report at Codecov.
|
atugushev
force-pushed
the
fix-output-file-for-setup-py
branch
from
23793fd
to
6dd97c2
Compare
|
Since a branch |
blueyed
reviewed
Feb 8, 2019
atugushev
force-pushed
the
fix-output-file-for-setup-py
branch
from
05a59ce
to
4304584
Compare
|
Hello @blueyed. Gentle ping. Is everything okay in the PR. Could you approve or request any changes if you'd like. |
blueyed
approved these changes
Feb 27, 2019
atugushev
force-pushed
the
fix-output-file-for-setup-py
branch
from
4304584
to
682b184
Compare
|
I've resolved conflicts, rebased and squashed commits. I'll merge this as soon as tests are passed. @blueyed, thanks for your help! |
…ce file The command `pip-compile setup.py` generates a `setup.txt`, but it should be a requirements.txt file.
atugushev
force-pushed
the
fix-output-file-for-setup-py
branch
from
682b184
to
37ae661
Compare
blueyed
approved these changes
Feb 28, 2019
atugushev
added a commit
to atugushev/pip-tools
that referenced
this pull request
Feb 28, 2019
The `pip-compile setup.py --output-file=output.txt` ignores `--output-file` option and compiles to a `requirements.txt` file.
blueyed
added a commit
that referenced
this pull request
Feb 28, 2019
Fix a regression bug introduced in #731 PR
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
pip-compile setup.pygenerates asetup.txt, butit should be a requirements.txt file.
Fixes #730.
Changelog-friendly one-liner: Fix the output file for pip-compile with an explicit setup.py as source file
Contributor checklist