Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify sync's logging with compile's logging system #1241

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Unify sync's logging with compile's logging system #1241

merged 1 commit into from
Nov 25, 2020

Conversation

jdufresne
Copy link
Member

sync now uses the same cumulative --verbose/--quiet as compile. sync
output calls go through the LogContext object.

Contributor checklist
  • Provided the tests for the changes. (already exist)
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@jdufresne jdufresne added this to the 5.5.0 milestone Nov 23, 2020
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Thanks 👍

@atugushev atugushev added enhancement Improvements to functionality cli Related to command line interface things labels Nov 25, 2020
sync now uses the same cumulative --verbose/--quiet as compile. sync
output calls go through the LogContext object.
@jdufresne jdufresne merged commit 2cef502 into jazzband:master Nov 25, 2020
@jdufresne jdufresne deleted the unify-logging branch November 25, 2020 22:22
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to command line interface things enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants