Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README example outputs for primary req annotations #1072

Merged
merged 2 commits into from
Feb 23, 2020

Conversation

richafrank
Copy link
Contributor

@richafrank richafrank commented Feb 20, 2020

I was excited for #1058 and noticed the README was now out of date, so I re-ran all the examples and captured their outputs.

Changelog-friendly one-liner: Updated README example outputs for primary req annotations

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #1072 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1072      +/-   ##
==========================================
+ Coverage   99.47%   99.51%   +0.04%     
==========================================
  Files          34       34              
  Lines        2476     2476              
  Branches      312      312              
==========================================
+ Hits         2463     2464       +1     
  Misses          6        6              
+ Partials        7        6       -1     
Impacted Files Coverage Δ
piptools/repositories/pypi.py 95.65% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 870b4fe...88266ce. Read the comment docs.

@atugushev atugushev added the docs Documentation related label Feb 21, 2020
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for noticing!

README.rst Outdated Show resolved Hide resolved
@atugushev atugushev added this to the 4.5.1 milestone Feb 21, 2020
@atugushev atugushev merged commit 8a288f3 into jazzband:master Feb 23, 2020
@atugushev
Copy link
Member

Perfect! Thanks @richafrank 🙏

@richafrank richafrank deleted the primary-annotations-readme branch February 23, 2020 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants