Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the --build-isolation flag set on by default for pip-compile. #1060

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Make the --build-isolation flag set on by default for pip-compile. #1060

merged 1 commit into from
Mar 4, 2020

Conversation

hramezani
Copy link
Member

Fixes #1030

Make the --build-isolation flag set on by default for pip-compile.

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@hramezani hramezani added this to the 5.0.0 milestone Feb 9, 2020
@codecov
Copy link

codecov bot commented Feb 9, 2020 •
edited
Loading

Codecov Report

Merging #1060 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files          34       34           
  Lines        2411     2411           
  Branches      297      297           
=======================================
  Hits         2397     2397           
  Misses          8        8           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 888c2a1...d75234d. Read the comment docs.

@hramezani hramezani added backwards incompatible Backwards incompatible change cli Related to command line interface things enhancement Improvements to functionality labels Feb 10, 2020
atugushev
atugushev approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@atugushev
Copy link
Member

atugushev commented Feb 14, 2020 •
edited
Loading

⚠️ To maintainers, please don't merge this until we decide to break master to 5.0.0 version.

@atugushev
Copy link
Member

@hramezani could you please resolve the conflicts, I'm going to merge this PR?

@hramezani
Copy link
Member Author

Yes, Sure. I will do it soon.

@hramezani
Copy link
Member Author

@atugushev It is ready.

@atugushev atugushev merged commit 83fa590 into jazzband:master Mar 4, 2020
@atugushev
Copy link
Member

@hramezani thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atugushev atugushev atugushev approved these changes

Assignees
No one assigned
Labels
backwards incompatible Backwards incompatible change cli Related to command line interface things enhancement Improvements to functionality
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Make the --build-isolation flag set on by default for pip-compile
2 participants
@hramezani @atugushev