Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade click version in setup.py #1039

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Jan 22, 2020

Change click version in setup.py.
fix #1038
Changelog-friendly one-liner: Upgrade click version in setup.py.

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev changed the title Change click version in setup.py. fix #1038 Upgrade click version in setup.py Jan 22, 2020
@atugushev atugushev added this to the 4.4.1 milestone Jan 22, 2020
@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #1039 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1039   +/-   ##
======================================
  Coverage    99.5%   99.5%           
======================================
  Files          34      34           
  Lines        2406    2406           
  Branches      306     306           
======================================
  Hits         2394    2394           
  Misses          6       6           
  Partials        6       6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86cb063...ba35791. Read the comment docs.

@vphilippon vphilippon self-requested a review January 22, 2020 15:04
Copy link
Member

@vphilippon vphilippon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@atugushev atugushev merged commit 30e90be into jazzband:master Jan 22, 2020
@DeTeReR
Copy link

DeTeReR commented Jan 22, 2020

Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup.py install_requires should have "click>=7" not "click>=6"
4 participants