Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flake8 with ruff #256

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 26, 2023

Closes #255

This is a subset of

And a superset of

#253 is taking a lot of time to be reviewed and merged so let's establish on this subset...

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e7b9365) 93.83% compared to head (e815c9b) 93.83%.

Files Patch % Lines
formtools/wizard/views.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files          11       11           
  Lines         535      535           
  Branches       87       87           
=======================================
  Hits          502      502           
  Misses         21       21           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cclauss cclauss force-pushed the replace-flake8-with-ruff branch 2 times, most recently from 72fcf3c to a08a53a Compare November 26, 2023 16:10
.pre-commit-config.yaml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@cclauss cclauss requested a review from claudep November 26, 2023 16:38
Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good now!

@claudep claudep merged commit e56c457 into jazzband:master Nov 26, 2023
7 of 8 checks passed
@cclauss cclauss deleted the replace-flake8-with-ruff branch November 26, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants