Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Liveinternet #223

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add Liveinternet #223

wants to merge 5 commits into from

Conversation

odi1n
Copy link

@odi1n odi1n commented Sep 14, 2022

Addition service Liveinternet. Several implementation options have been made as per the documentation:

  1. in the form of a single image combining the counter and the LiveInternet logo
  2. in the form of two images, one of which is a counter (transparent GIF size 1x1), and the other is the LiveInternet logo. This placement method will allow you to insert the code of the invisible counter at the beginning of the page, and the logo - where the design and content of the page allows.

Copy link
Member

@bittner bittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! If it works on your end.

Can you please add tests to make the implementation complete?

Take a look at the other modules, if you need inspiration. It's easy and quick to do.

Thank you! 👍

docs/services/liveinternet.rst Show resolved Hide resolved
docs/services/liveinternet.rst Outdated Show resolved Hide resolved
odi1n and others added 3 commits September 19, 2022 16:42
Co-authored-by: Peter Bittner <django@bittner.it>
@odi1n
Copy link
Author

odi1n commented Sep 19, 2022

Looks good to me! If it works on your end.

Can you please add tests to make the implementation complete?

Take a look at the other modules, if you need inspiration. It's easy and quick to do.

Thank you! 👍

Kind of implemented all the wishes 😊

@odi1n odi1n requested a review from bittner September 19, 2022 15:55
@bittner
Copy link
Member

bittner commented Sep 26, 2022

Flake8 and isort found 3 minor issues, and some of your tests are failing. Can you fix that?

@odi1n
Copy link
Author

odi1n commented Sep 26, 2022

Flake8 и isort обнаружили 3 незначительные проблемы, и некоторые из ваших тестов не работают. Вы можете это исправить?

I don't have a lot of time right now, so I can't. As soon as I'm free, if I don't forget, I'll fix it.

@bittner
Copy link
Member

bittner commented Sep 26, 2022

I don't have a lot of time right now, so I can't. As soon as I'm free, if I don't forget, I'll fix it.

It's all good, take your time. Your contribution is good on track at the moment. Unfortunately, it's necessary to satisfy some basic code quality metrics. There's not much missing, though, really. Thank you for your understanding! Maybe set yourself a reminder. ⏱️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants