Fixed error for Matomo (return code 500-php/server error) - no parent… #159
Conversation
…heses in site-code' Fixed the log-level (trace) for not configured search engines Added the option to disable the tracking code
|
Your PR needs to be rebased to be eligible for being merged.
This sounds like an arrogant statement. I'm sure you don't mean it that way. If your changes need tests to be adapted I'm afraid there is no other choice than getting that done, too. If you write tests, if you refactor tests, if you improve tests, that demonstrates professional attitude. If you break tests, that is something that would be unprofessional from our side to accept. We can't do that. What we can do is offer our support. Let us know where you struggle with aligning the existing tests with your changes. There will be someone taking their time – even if "we don't have it", even when our families would deserve that time more. That's how we people are in the free software community. Ask us! We're happy about your contribution, and we're here to help. |
|
Any chance you would rebase your branch for this PR, @rristow? If you need any help for adjusting the tests afterwards, please let us know! |
| from analytical.utils import get_identity, is_internal_ip, disable_html, \ | ||
| get_required_setting | ||
|
|
||
| get_required_setting |
There was a problem hiding this comment.
How about?
from analytical.utils import (
disable_html,
get_identity,
get_required_setting,
is_internal_ip,
)| from analytical.utils import disable_html, get_required_setting, \ | ||
| is_internal_ip, get_user_from_context, get_identity, \ | ||
| get_user_is_authenticated | ||
| is_internal_ip, get_user_from_context, get_identity, \ | ||
| get_user_is_authenticated |
There was a problem hiding this comment.
Don't isort and black like something like this better?
from analytical.utils import (
disable_html,
get_identity,
get_required_setting,
get_user_from_context,
get_user_is_authenticated,
is_internal_ip,
)| from analytical.utils import is_internal_ip, disable_html, get_identity, \ | ||
| get_required_setting | ||
|
|
||
| get_required_setting |
| from analytical.utils import is_internal_ip, disable_html, \ | ||
| get_required_setting | ||
|
|
||
| get_required_setting |
| from analytical.utils import get_identity, is_internal_ip, disable_html, \ | ||
| get_required_setting | ||
|
|
||
| get_required_setting |
| from analytical.utils import is_internal_ip, disable_html, \ | ||
| get_required_setting | ||
|
|
||
| get_required_setting |
Sorry, no time to improve the tests