Allow separating the WWN vendor extension #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a way to get the disk WWN without the vendor extension. Signed-off-by: Zane Bitter <zbitter@redhat.com>
|
Well hello there, @zaneb! :) |
jaypipes
approved these changes
Mar 13, 2024
| @@ -233,9 +233,13 @@ type Disk struct { | |||
| Model string `json:"model"` | |||
| // SerialNumber is the serial number of the disk. | |||
| SerialNumber string `json:"serial_number"` | |||
| // WWN is the World-wide Number of the disk. | |||
There was a problem hiding this comment.
LOL, thanks for the correction!
|
Thanks @jaypipes! Hope you're also doing well 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a way to get the disk WWN without the vendor extension.
Ironic root device hints support matching separately on the WWN, vendor extension, and WWN+extension. This makes it useful to be able to separate the vendor extension from the base WWN.