Read core and physical package ID of the CPUs that are online

[kishen-v]

Fixes: #361

Added check to fetch the physical_package_id/core_id after determining if the CPU is online.

[ffromani]

LGTM

any chance to add a test or two to exercise this code?

[kishen-v]

Hi @ffromani, I've added a couple of tests to check if the warning is being raised in the case of missing files (core_id/physical_package_id) in the topology directory. Could you PTAL when time permits?

Thanks!

[jaypipes]

Hi @kishen-v thanks very much for your contribution! One little suggestion inline for you...

[jaypipes]

this will return -1 if the file does not exist... perhaps it's worth changing this to:

if util.SafeIntFromFile(ctx, onlineFilePath) != 1 {

in order to account for when there are problems locating the /online file?

[kishen-v]

I agree. Addressed the comment.

Thanks!

[kishen-v]

It was observed that this change didn't fit well for the ARM architecture, as the online file does not exist under the cpuX directory. This lead to the mismatch in the expected vs observed tests results causing a breaking change.

The online file exists for the amd64/ppc64le architecture where, the corresponding files are in the topology directory may/may not exist based on the bit set in the online file. I have made changes to account only if the cpu is offline, before the files under the topology directory are checked. This doesn't seem to affect the arm64 architecture as the -1 returned from the caller doesn't affect the rest of the code execution.

Thanks!