assume phys mem == usable mem on ARM #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanyaoqi
reviewed
Apr 22, 2023
| totUsable, err := memoryTotalUsableBytesFromPath(filepath.Join(path, "meminfo")) | ||
| if err != nil { | ||
| return nil, err | ||
| blockSizeBytes, err = memoryBlockSizeBytes(paths.SysDevicesSystemMemory) |
There was a problem hiding this comment.
Hi @jaypipes , I think should use memTotalPhysicalBytes function here, memTotalPhysicalBytes will scan syslog to get physical size, and check return value > 0 to decide whether to use totUsable memory.
ghw/pkg/memory/memory_linux.go
Lines 105 to 113 in 227643e
There was a problem hiding this comment.
@wanyaoqi good point. done!
`/sys/devices/system/memory` does not exist on linux/arm systems that do not support memory hotplug. This means that the `/sys/devices/system/memory/block_size_bytes` file also does not exist and that is the file that we use to determine the physical RAM associated with a RAM module affined to a NUMA node. This commit updates the logic in `pkg/memory.AreaForNode` on linux platforms to tolerate the error returned by `memoryBlockSizeBytes()` when `/sys/devices/system/memory/block_size_bytes` does not exist and set a memory `Area`'s `TotalPhysicalBytes` value to the value of either the syslog-determined physical memory total or `TotalUsableBytes`. Issue #336 Signed-off-by: Jay Pipes <jaypipes@gmail.com>
|
@ffromani any chance you have some time to review this one? :) |
done and merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/sys/devices/system/memorydoes not exist on linux/arm systems that do not support memory hotplug. This means that the/sys/devices/system/memory/block_size_bytesfile also does not exist and that is the file that we use to determine the physical RAM associated with a RAM module affined to a NUMA node.This commit updates the logic in
pkg/memory.AreaForNodeon linux platforms to tolerate the error returned bymemoryBlockSizeBytes()when/sys/devices/system/memory/block_size_bytesdoes not exist and set a memoryArea'sTotalPhysicalBytesvalue to the value ofTotalUsableBytes.Issue #336