util: add helper to avoid long format strings #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A relatively common pattern in the ghw codebase is concatenating quite a lot of strings inside a format string. This leads to a pattern like '%s%s%s%s%s' which are hard to read and to debug. Ad a simple helper to concatenate strings to simplify the format strings. This may be the definitive solution here, but it should improve the maintenability and readability, and it's very cheap to implement and maintain. Signed-off-by: Francesco Romani <fromani@redhat.com>
jaypipes
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A relatively common pattern in the ghw codebase
is concatenating quite a lot of strings inside
a format string. This leads to a pattern like '%s%s%s%s%s'
which are hard to read and to debug.
Ad a simple helper to concatenate strings to simplify the
format strings.
This may be the definitive solution here, but
it should improve the maintenability and readability,
and it's very cheap to implement and maintain.
Signed-off-by: Francesco Romani fromani@redhat.com