rename PCIAddress.Slot to PCIAddress.Device #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffromani
reviewed
May 22, 2021
pkg/pci/pci_linux.go
Outdated
| @@ -40,7 +40,7 @@ func getDeviceModaliasPath(ctx *context.Context, address string) string { | |||
| } | |||
| return filepath.Join( | |||
| paths.SysBusPciDevices, | |||
| pciAddr.Domain+":"+pciAddr.Bus+":"+pciAddr.Slot+"."+pciAddr.Function, | |||
| pciAddr.Domain+":"+pciAddr.Bus+":"+pciAddr.Device+"."+pciAddr.Function, | |||
There was a problem hiding this comment.
We should just use pciAddr.String() here - perhaps in a later patch
ffromani
reviewed
May 22, 2021
As noted by @pearsonk in #220, the PCIAddress.Slot field was a bit of a misnomer, since the more common representation of a PCIAddress is Bus:Device.Function, not Bus:Slot.Function. Actual PCI slot information may be retrieved from DMI, but what we were referring to was not the actual PCI slot information but rather the PCI address device component. Fixes Issue #220
jaypipes
force-pushed
the
pci-slot-to-device
branch
from
587fae4
to
9c46440
Compare
|
Looks great to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted by @pearsonk in #220, the PCIAddress.Slot field was a bit of a
misnomer, since the more common representation of a PCIAddress is
Bus:Device.Function, not Bus:Slot.Function. Actual PCI slot information
may be retrieved from DMI, but what we were referring to was not the
actual PCI slot information but rather the PCI address device component.
Fixes Issue #220