block: read procfs, not /etc/mtab #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reason for this change: https://github.com/systemd/systemd/blob/v227/NEWS#L9-L14 |
ffromani
force-pushed
the
stop-reading-mtab
branch
from
7e1b0bf
to
db160bc
Compare
ffromani
changed the title
jaypipes
reviewed
Jun 8, 2021
Turns out /etc/mtab is long time deprecated, as it is documented in the systemd docs: https://github.com/systemd/systemd/blob/v227/NEWS#L9-L14 Hence, better stop consuming it and read `/proc/self/mounts` (which /etc/mtab is supposed to be asymlink of anyway) instead. The format of the file is the same. Signed-off-by: Francesco Romani <fromani@redhat.com>
ffromani
force-pushed
the
stop-reading-mtab
branch
from
db160bc
to
8269002
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out
/etc/mtabis long time deprecated, as it is documentedin the systemd docs: https://github.com/systemd/systemd/blob/v227/NEWS#L9-L14
Hence, better stop consuming it and read
/proc/self/mounts(which/etc/mtabis supposed to be a symlink of anyway) instead.The format of the file is the same.
Signed-off-by: Francesco Romani fromani@redhat.com