Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1-wire analyser works incorrect #228

Open
aivs opened this issue Nov 4, 2015 · 2 comments
Open

1-wire analyser works incorrect #228

aivs opened this issue Nov 4, 2015 · 2 comments

Comments

@aivs
Copy link

aivs commented Nov 4, 2015

On dangerousprototypes.com/forum I found, that users can successfully analyze 1-wire.
But for me 1-wire analyser not works correctly.
See screenshots:
screenshot7
by arhi » Wed Sep 07, 2011 10:33 pm - All OK

1-wire-analyzer
by aivs » Tue Nov 03, 2015 4:49 pm - Bad analyzed bytes (ols 0.9.7.2 with Arduino UNO)

As you can see, impulses are identical, but analyzed bytes different.
Can you check, is 1-wire analyzer works?

@tudorp
Copy link
Contributor

tudorp commented Sep 18, 2016

Dear aivs,

I did encounter very similar issues regarding onewire timing and parsing while working with DS1820 and another Dalas one wire memory within a dell lapto charger. Based on my investigation the problem is connected with over-simplified pulse tracing/parsing and with timing limits that are not close enough to the one wire protocol specifications (e.g. http://pdfserv.maximintegrated.com/en/an/AN937.pdf). I am working on a fix and preparing a pull request.

tudorp added a commit to tudorp/ols that referenced this issue Sep 18, 2016
…constants to better match datasheet tolerances
jawi added a commit that referenced this issue Sep 22, 2016
issue #228 - improved one wire signal tracing and adapted timing const.

@tudorp : thanks for the fix!
@jawi
Copy link
Owner

jawi commented Sep 22, 2016

@tudorp : it appears your changes caused a test failure in the 1-wire decoder. Are you able to verify whether this is due to a faulty test or due to your changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants