Skip to content
This repository has been archived by the owner on Feb 5, 2019. It is now read-only.

Fix (un)marshal bug #1135 #1155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix (un)marshal bug #1135 #1155

wants to merge 1 commit into from

Conversation

NiasSt90
Copy link

@NiasSt90 NiasSt90 commented Nov 8, 2017

i'm not sure if the hasSubClasses() is enough in all cases.
perhaps there should be a general way to disable this optimization on demand/fallback (system-property).

it works in my case (see the reproducer project mentioned in the bug report).

@vrlgohel
Copy link

Hi Guys,

Can some one please review the change and know if any further changes are required ?

@gaol
Copy link

gaol commented Jan 16, 2018

@bravehorsie @zhengjl Would you please review it? Thank you very much! :)

@vrlgohel
Copy link

vrlgohel commented Mar 5, 2018

@bravehorsie, @zhengjl, guys, can you please review these changes ?

@bravehorsie
Copy link
Member

Looks type information is lost due to @XmlValue. I need to look further at it to be sure, but so far the change does look good to me.
However we are in a process of migrating jaxb-ri to Eclipse Foundation and untill completed accepting only "critical" PRs.

@vrlgohel
Copy link

@bravehorsie, thanks for reviewing this. We have a user business use case that needs a fix on this. If the changes seems to be fine, can we include them in jaxb-v2 on the latest branch ?

@vrlgohel
Copy link

Guys, is there any update on this ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants