Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Upgrading derby and fixing assembly logic. #22606

Merged
merged 3 commits into from
Jan 7, 2019

Conversation

ankathur
Copy link
Member

No description provided.

@ankathur
Copy link
Member Author

@glassfishrobot Run CI tests please

@glassfishrobot
Copy link
Contributor

Starting CI tests run

@glassfishrobot
Copy link
Contributor

One or more CI tests failed

@ankathur
Copy link
Member Author

@glassfishrobot Run CI tests please

@glassfishrobot
Copy link
Contributor

Starting CI tests run

@glassfishrobot
Copy link
Contributor

One or more CI tests failed

@ankathur
Copy link
Member Author

@glassfishrobot Run CI tests please

@glassfishrobot
Copy link
Contributor

Starting CI tests run

@glassfishrobot
Copy link
Contributor

One or more CI tests failed

@ankathur
Copy link
Member Author

ankathur commented Jan 2, 2019

@glassfishrobot Run CI tests please

@glassfishrobot
Copy link
Contributor

Starting CI tests run

@glassfishrobot
Copy link
Contributor

One or more CI tests failed

@@ -111,7 +111,7 @@
<dbschema.version>6.6</dbschema.version>
<schema2beans.version>6.6</schema2beans.version>
<mq.version>5.1.2-b01</mq.version>
<derby.version>10.13.1.1</derby.version>
<derby.version>10.13.1.2</derby.version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this official derby release? I can't see it in maven central.
Why not upgrade to 10.14.2.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It comes out of repackaged project which is packaging derby 10.14.2.0. It is released as "org.glassfish.external:derby"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It comes out of repackaged project which is packaging derby 10.14.2.0. It is released as "org.glassfish.external:derby"
thanks for update

I found it a bit confusing (10.13 vs. 10.14). [It wouldn't be if versions were much, much different, and not so similar 😉.)

But you are definitely right, derby-10.13.1.2.pom references 10.14.2.0.
Thanks for the reply.

Copy link
Member

@jigneshbhodia jigneshbhodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jigneshbhodia jigneshbhodia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jigneshbhodia jigneshbhodia merged commit f53664b into javaee:master Jan 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants