-
Notifications
You must be signed in to change notification settings - Fork 191
Upgrading derby and fixing assembly logic. #22606
Conversation
@glassfishrobot Run CI tests please |
Starting CI tests run |
One or more CI tests failed |
@glassfishrobot Run CI tests please |
Starting CI tests run |
One or more CI tests failed |
@glassfishrobot Run CI tests please |
Starting CI tests run |
One or more CI tests failed |
@glassfishrobot Run CI tests please |
Starting CI tests run |
One or more CI tests failed |
@@ -111,7 +111,7 @@ | |||
<dbschema.version>6.6</dbschema.version> | |||
<schema2beans.version>6.6</schema2beans.version> | |||
<mq.version>5.1.2-b01</mq.version> | |||
<derby.version>10.13.1.1</derby.version> | |||
<derby.version>10.13.1.2</derby.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this official derby release? I can't see it in maven central.
Why not upgrade to 10.14.2.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It comes out of repackaged project which is packaging derby 10.14.2.0. It is released as "org.glassfish.external:derby"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It comes out of repackaged project which is packaging derby 10.14.2.0. It is released as "org.glassfish.external:derby"
thanks for update
I found it a bit confusing (10.13 vs. 10.14). [It wouldn't be if versions were much, much different, and not so similar 😉.)
But you are definitely right, derby-10.13.1.2.pom references 10.14.2.0.
Thanks for the reply.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.