SSL params bug fixes and improvements #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request jasonrbriggs#6 broke SSL connections: * get_ssl while connecting should receive the host and port we are trying to connect to, since current_host_and_port may not be set yet. * local variable ssl redefines ssl module, shadowing it * SSL connection test fails, however there's an except block catching all errors and test pass even if it shouldn't. * Expose set_ssl/get_ssl methods to connection objects
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #6 broke SSL connections:
trying to connect to, since current_host_and_port may not be set yet.
all errors and test pass even if it shouldn't.