Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runfo edits issues when there is no change #165

Closed
ericstj opened this issue Aug 4, 2022 · 4 comments · Fixed by #166
Closed

Runfo edits issues when there is no change #165

ericstj opened this issue Aug 4, 2022 · 4 comments · Fixed by #166

Comments

@ericstj
Copy link
Contributor

ericstj commented Aug 4, 2022

I noticed that Runfo will continuously edit live issues, filling up the issue edit history and making it very difficult to go back and see trends. @ViktorHofer also mentioned that this is unbounded growth the GitHub's issue storage as well.

@ViktorHofer
Copy link

cc @jaredpar

@jaredpar
Copy link
Owner

jaredpar commented Aug 5, 2022

@ViktorHofer also mentioned that this is unbounded growth the GitHub's issue storage as well.

How do you view this? Never seen issue storage displayed anywhere before.

I noticed that Runfo will continuously edit live issues, filling up the issue edit history and making it very difficult to go back and see trends

Let me see how easy that is to fix.

jaredpar added a commit that referenced this issue Aug 5, 2022
Don't update an issue if the report body hasn't changed.

closes #165
jaredpar added a commit that referenced this issue Aug 5, 2022
Don't update an issue if the report body hasn't changed.

closes #165
@jaredpar
Copy link
Owner

jaredpar commented Aug 5, 2022

Verified the fix is working

2022-08-05T02:37:14.550 [Information] Executing 'issues-update-manual' (Reason='This function was programmatically called via the host APIs.', Id=b7397ac2-d2ce-4372-adff-ac95803705d6)
2022-08-05T02:37:17.122 [Information] Updating 415
2022-08-05T02:37:19.475 [Information] No change in body, skipping update
2022-08-05T02:37:19.476 [Information] Updated dotnet/runtime#73343
2022-08-05T02:37:19.486 [Information] Executed 'issues-update-manual' (Succeeded, Id=b7397ac2-d2ce-4372-adff-ac95803705d6, Duration=5558ms)

@ViktorHofer
Copy link

How do you view this? Never seen issue storage displayed anywhere before.

AFAIK there's no way to access that data but these unnecessary updates might cause storage issues eventually. We saw something similar in dotnet/runtime#68440 which we fixed by cleaning up the old workflow runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants