Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add agilgur5 as a contributor #446

Merged
merged 3 commits into from
Jan 24, 2020
Merged

Conversation

allcontributors[bot]
Copy link
Contributor

Adds @agilgur5 as a contributor for maintenance, doc, code, test.

This was requested by sw-yx in this comment

@swyxio swyxio merged commit 77c28d0 into master Jan 24, 2020
@swyxio swyxio deleted the all-contributors/add-agilgur5 branch January 24, 2020 14:57
@agilgur5
Copy link
Collaborator

Thanks for the credits @sw-yx !

Could you also add me for:

Not sure that I can tag the bot myself?


Also since I'm semi-officially a maintainer here (thanks!) and being tagged in some places -- could I have some elevated permissions? I'd like to at least be able to rename, close, & tag issues I respond to as right now I have to wait for OP or you or Jared to do that. I can leave PR merges to you & Jared as they are now (unless you're ok with me merging some things). Up to you of course

@swyxio
Copy link
Collaborator

swyxio commented Feb 2, 2020

i dont have permissions to give permissions :)

@all-contributors please add @agilgur5 for bug, example, ideas, question, review

@allcontributors
Copy link
Contributor Author

@sw-yx

I've put up a pull request to add @agilgur5! 🎉

@agilgur5
Copy link
Collaborator

agilgur5 commented Feb 2, 2020

ah, gotcha 😕 thanks for the add!

@agilgur5
Copy link
Collaborator

agilgur5 commented Feb 2, 2020

Huh, just noticed I don't have "tests" in the README despite being added here.

Thought it might be a bug in all-contributors, but it's actually not, it was caused by a merge conflict above here. Related to all-contributors/app#62 for which merge conflicts, particularly of multiple bot PRs are a big use case.

@agilgur5
Copy link
Collaborator

@all-contributors please add @agilgur5 for tests

See above comment since it got missed before. Figure the bulk of these can go in one release.

@allcontributors
Copy link
Contributor Author

@agilgur5

I've put up a pull request to add @agilgur5! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants