Skip to content

Commit

Permalink
feat(filter): allow map of filters to be registered
Browse files Browse the repository at this point in the history
This feature adds similar functionality to what `$ControllerProvider.register`
and `$CompileProvider.directive` currently provide by allowing a map of filter
name/factories to be passed as the sole argument to `$FilterProvider.register`
to register all of the specified filters.

Closes angular#4036
Closes angular#4091
  • Loading branch information
colincasey authored and jamesdaily committed Jan 27, 2014
1 parent 549dee4 commit 1a7adc1
Show file tree
Hide file tree
Showing 2 changed files with 66 additions and 2 deletions.
21 changes: 19 additions & 2 deletions src/ng/filter.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,32 @@ $FilterProvider.$inject = ['$provide'];
function $FilterProvider($provide) {
var suffix = 'Filter';

/**
* @ngdoc function
* @name ng.$controllerProvider#register
* @methodOf ng.$controllerProvider
* @param {string|Object} name Name of the filter function, or an object map of filters where
* the keys are the filter names and the values are the filter factories.
* @returns {Object} Registered filter instance, or if a map of filters was provided then a map
* of the registered filter instances.
*/
function register(name, factory) {
return $provide.factory(name + suffix, factory);
if(isObject(name)) {
var filters = {};
forEach(name, function(filter, key) {
filters[key] = register(key, filter);
});
return filters;
} else {
return $provide.factory(name + suffix, factory);
}
}
this.register = register;

this.$get = ['$injector', function($injector) {
return function(name) {
return $injector.get(name + suffix);
}
};
}];

////////////////////////////////////////
Expand Down
47 changes: 47 additions & 0 deletions test/ng/filterSpec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
'use strict';

describe('$filter', function() {
var $filterProvider, $filter;

beforeEach(module(function(_$filterProvider_) {
$filterProvider = _$filterProvider_;
}));

beforeEach(inject(function(_$filter_) {
$filter = _$filter_;
}));

describe('provider', function() {
it('should allow registration of filters', function() {
var FooFilter = function() {
return function() { return 'foo'; };
};

$filterProvider.register('foo', FooFilter);

var fooFilter = $filter('foo');
expect(fooFilter()).toBe('foo');
});

it('should allow registration of a map of filters', function() {
var FooFilter = function() {
return function() { return 'foo'; };
};

var BarFilter = function() {
return function() { return 'bar'; };
};

$filterProvider.register({
'foo': FooFilter,
'bar': BarFilter
});

var fooFilter = $filter('foo');
expect(fooFilter()).toBe('foo');

var barFilter = $filter('bar');
expect(barFilter()).toBe('bar');
});
});
});

0 comments on commit 1a7adc1

Please sign in to comment.