WIP: Optimize pdist's handling of diagonal chunks #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
force-pushed
the
opt_gen_pdist_diag_2
branch
8 times, most recently
from
00ea49e
to
e687cf4
Compare
|
After a fair bit of tweaking, this still appears to be a bit slower than no optimization for the diagonal at all. It might be possible to improve on this by recursively calling |
jakirkham
changed the title
Make use of `cdist` for computing the bulk of the results for `pdist`. However drop all duplicate chunks on the opposite side of the diagonal. Though keep all chunks on the right side of the diagonal. As for any chunks that land on the diagonal, break them up into pieces that include non-duplicated pairs and pass those through `cdist` as well. Take all of these results and flatten them so that they can be concatenated into one big result.
jakirkham
force-pushed
the
opt_gen_pdist_diag_2
branch
from
e687cf4
to
933fa03
Compare
|
While this remains the best option for optimizing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR ( #81 ).
Fixes #92
Make use of
cdistfor computing the bulk of the results forpdist. However drop all duplicate chunks on the opposite side of the diagonal. Though keep all chunks on the right side of the diagonal. As for any chunks that land on the diagonal, break them up into pieces that include non-duplicated pairs and pass those throughcdistas well. Take all of these results and flatten them so that they can be concatenated into one big result.