Support more metrics in cdist and pdist #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
force-pushed
the
dist_more_metrics
branch
2 times, most recently
from
6bcf9f9
to
8062d32
Compare
Adds support for the `mahalanobis`, `seuclidean`, and `wminkowski` metrics in `cdist` and `pdist`. Includes supporting default arguments for these different metrics in `cdist` and `pdist` as needed. Provides tests against the SciPy equivalents for all of these functions and metrics with and without default arguments filled in.
jakirkham
force-pushed
the
dist_more_metrics
branch
from
8062d32
to
80534f2
Compare
jakirkham
commented
Sep 30, 2017
| elif kw["V"] is None: | ||
| kw.pop("V") | ||
| elif metric == "wminkowski": | ||
| kw["w"] = np.random.random(u_shape[-1:]) |
There was a problem hiding this comment.
Were unable to test negative values as well due to issue ( scipy/scipy#7953 ).
jakirkham
commented
Sep 30, 2017
| elif kw["V"] is None: | ||
| kw.pop("V") | ||
| elif metric == "wminkowski": | ||
| kw["w"] = np.random.random(u_shape[-1:]) |
There was a problem hiding this comment.
Were unable to test negative values as well due to issue ( scipy/scipy#7953 ).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
mahalanobis,seuclidean, andwminkowskimetrics incdistandpdist. Includes supporting default arguments for these different metrics incdistandpdistas needed. Provides tests against the SciPy equivalents for all of these functions and metrics with and without default arguments filled in.