Fix ravel chunking #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `atop`, our internal `ravel` implementation was setting the chunks of the first axis of the input. However it should be setting the chunks of the new axis in the output instead, which is what we change it to here.
The `atop`-based `ravel` implementation was previously using the `concatenate` argument with `atop`. This apparently was pulling the whole array into memory at once, which is probably a bad idea. To fix that, we drop the `concatenate` argument. However that means we need to make some other changes as well. So we `rechunk` beforehand such that the last dimension is equivalent to the array's shape. This makes `ravel` a trivial operation for each chunk.
jakirkham
force-pushed
the
fix_ravel_chks
branch
from
0059d85
to
1042e9c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop use of
concatenateas it is drawing all chunks into memory. Rechunkato make theraveloperation trivial. Fix chunk adjustment for the last axis.Note: This ends up being slower than
ravelthat is available in newer versions of Dask.