maps color format from HEIF to Qt (i.e. RGB88) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
diemmarkus
commented
Jun 22, 2020
diemmarkus
commented
- this patch is needed to load RGB888 heif images with libheif 1.7.0
- maps heif_chroma_interleaved_RGB to QImage::Format_RGB888
- other conversions are not added because I don't have test images
- this patch is needed to load RGB888 heif images with libheif 1.7.0 - maps heif_chroma_interleaved_RGB to QImage::Format_RGB888 - other conversions are not added because I don't have test images
|
having compiled libheif v1.7.0 I could not load C001.heic anymore. |
I could send you test image. Do you need it? |
|
yes, please! (ideally with different color formats) |
It's photo taken from my mobile phone: http://zawertun.crabdance.com/20200620_175651.heic. |
|
Merged without testing, because
Thanks everyone! |
|
Just reread your comments, and my merge might have been premature. Sorry if that's the case. |
it should be fine. Only, if we have images stored in formats other than RGB and RGBA, we should come back to this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.