Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI for js config #2732

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

th3M1ke
Copy link
Contributor

@th3M1ke th3M1ke commented Jan 18, 2021

Which problem is this PR solving?

Short description of the changes

@th3M1ke th3M1ke requested a review from a team as a code owner January 18, 2021 12:57
@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #2732 (f646e3b) into master (8fb235a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2732   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files         217      217           
  Lines        9628     9628           
=======================================
  Hits         9221     9221           
  Misses        335      335           
  Partials       72       72           
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 96.77% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb235a...f646e3b. Read the comment docs.

Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io>
@yurishkuro yurishkuro merged commit 1cd2725 into jaegertracing:master Jan 18, 2021
@albertteoh
Copy link
Contributor

We're keen to use the JS config feature in Jaeger UI as well as picking up the new navigation bar changes. Is it a good time for a new release? If so, I'm happy to do the work with preparing the release, if the maintainers are okay with it, of course. :)

@yurishkuro
Copy link
Member

Let's discuss on #2734

bhiravabhatla pushed a commit to bhiravabhatla/jaeger that referenced this pull request Jan 25, 2021
Signed-off-by: Mykhailo Semenchenko <mykhailo.semenchenko@logz.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants