-
Notifications
You must be signed in to change notification settings - Fork 155
Conversation
jaeger_client/config.py
Outdated
@@ -303,6 +303,25 @@ def local_agent_reporting_host(self) -> str: | |||
else: | |||
return DEFAULT_REPORTING_HOST | |||
|
|||
@property | |||
def local_agent_reporting_host_use_ipv6(self) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're automatically determining if the address is IPv6-only, what is the value proposition of this new property? To put it differently, what is the downside of not exposing it and always handling the v4/v6 automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resonable. Added _create_socket
method to TUDPTransport class, that can be overriden, removed config options.
Also, socket.set_blocking() requires boolean, so i removed the following block (perhaps there is a reason to keep it):
if blocking:
blocking = 1
else:
blocking = 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added tests
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
==========================================
+ Coverage 95.30% 95.32% +0.01%
==========================================
Files 25 25
Lines 2046 2053 +7
Branches 275 275
==========================================
+ Hits 1950 1957 +7
Misses 61 61
Partials 35 35
Continue to review full report at Codecov.
|
Signed-off-by: Alexander Vasin <hi@alvass.in>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Added ability to report spans to ipv6 only hosts using:
local_agent.reporting_host_use_ipv6
optionJAEGER_AGENT_HOST_USE_IPV6
environment variable.reporting_host
is ipv6 only.Resolves #337