This repository has been archived by the owner on Jul 11, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 155
Fix B3Codec's trace_id zero-padding for 32bit IDs #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Aug 28, 2021
yurishkuro
changed the title
fix B3Codec inject bug for traceid
Fix B3Codec's trace_id zero-padding for 32bit IDs
Aug 28, 2021
Also, please fix the DCO (see CONTRIBUTING.md) |
Thanks for the review! |
The DCO check is still failing, please sign all commits (see CONTRIBUTING) |
yurishkuro
approved these changes
Aug 29, 2021
Signed-off-by: mizhexiaoxiao <1157861072@qq.com>
Signed-off-by: mizhexiaoxiao <1157861072@qq.com>
Thank you for your patient reply, it should be ok now |
You can run "make lint" locally before submitting |
done :) |
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 95.42% 95.43%
=======================================
Files 25 25
Lines 1967 1971 +4
Branches 272 273 +1
=======================================
+ Hits 1877 1881 +4
Misses 56 56
Partials 34 34
Continue to review full report at Codecov.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
For example, if the traceid is 023f352eaefd8b887a06732f5312e2de, it will inject as 23f352eaefd8b887a06732f5312e2de, which will cause the trace to split into two because the traceid is different
Signed-off-by: mizhexiaoxiao 1157861072@qq.com