This repository has been archived by the owner on Jul 11, 2022. It is now read-only.
Add support for references #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 94.58% 94.63% +0.05%
==========================================
Files 25 25
Lines 1883 1902 +19
Branches 250 256 +6
==========================================
+ Hits 1781 1800 +19
Misses 67 67
Partials 35 35
Continue to review full report at Codecov.
|
- Checks if all the given references are valid - If the parent is not set then sets the first reference as parent of the span - Allows to pass one Reference object or list of them Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
bhavin192
force-pushed
the
support-references
branch
from
767e0cc
to
061a941
Compare
Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
approved these changes
Apr 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the span
Fixes #190