This repository has been archived by the owner on Jul 11, 2022. It is now read-only.
Enable windows support by isolating ioctl calls #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne Carriere <etienne.a.carriere@socgen.com>
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
- Coverage 94.91% 94.59% -0.33%
==========================================
Files 25 25
Lines 1848 1867 +19
Branches 245 247 +2
==========================================
+ Hits 1754 1766 +12
- Misses 61 66 +5
- Partials 33 35 +2
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Jan 12, 2019
jaeger_client/utils.py
Outdated
| if ip is None: | ||
| ip = get_local_ip_by_socket() | ||
| if ip is None: | ||
| ip = 'Unknown IP' |
There was a problem hiding this comment.
maybe it's better to skip the IP tag in this case? Returning invalid string as IP might break something downstream.
added 2 commits
January 14, 2019 10:56
Signed-off-by: Etienne Carriere <etienne.a.carriere@socgen.com>
Signed-off-by: Etienne Carriere <etienne.a.carriere@socgen.com>
|
@yurishkuro , could you please re-review ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : #189
Signed-off-by: Etienne Carriere etienne.a.carriere@socgen.com