Skip to content
This repository has been archived by the owner on Jul 11, 2022. It is now read-only.

Unpin flake8 to allow v3 #231

Merged
merged 2 commits into from
Jan 10, 2019
Merged

Unpin flake8 to allow v3 #231

merged 2 commits into from
Jan 10, 2019

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jan 10, 2019

and fix a few minor breaks

also remove tests from lint, because they were skipped in flake8 config anyway

Signed-off-by: Yuri Shkuro <ys@uber.com>
@black-adder
Copy link
Contributor

black-adder commented Jan 10, 2019

also remove tests from lint, because they were skipped in flake8 config anyway

I actually like linting tests... the whole codebase should conform; can we add a rule to flake8 config to run on tests?

Signed-off-by: Yuri Shkuro <ys@uber.com>
@yurishkuro
Copy link
Member Author

@black-adder I agree with you, however at the moment tests/ does not pass flake8 lint, and it is explicitly excluded from flake8 configuration in setup.cfg, so it was misleading to include the dir in the lint command.

Copy link
Contributor

@black-adder black-adder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough

@codecov
Copy link

codecov bot commented Jan 10, 2019

Codecov Report

Merging #231 into master will increase coverage by 0.1%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #231     +/-   ##
=========================================
+ Coverage    94.8%   94.91%   +0.1%     
=========================================
  Files          25       25             
  Lines        1848     1848             
  Branches      245      245             
=========================================
+ Hits         1752     1754      +2     
+ Misses         62       61      -1     
+ Partials       34       33      -1
Impacted Files Coverage Δ
crossdock/server/serializer.py 85.5% <0%> (ø) ⬆️
jaeger_client/sampler.py 100% <100%> (ø) ⬆️
jaeger_client/config.py 91.42% <85.71%> (ø) ⬆️
jaeger_client/throttler.py 96.36% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24603de...93b5ea5. Read the comment docs.

@yurishkuro yurishkuro merged commit 38524ad into master Jan 10, 2019
@ghost ghost removed the review label Jan 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants