This repository has been archived by the owner on Jul 11, 2022. It is now read-only.
Use String strategyType instead of int #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Won Jun Jang <wjang@uber.com>
yurishkuro
approved these changes
May 4, 2018
yurishkuro
reviewed
May 4, 2018
| @@ -449,10 +448,10 @@ def _update_adaptive_sampler(self, per_operation_strategies): | |||
|
|
|||
| def _update_rate_limiting_or_probabilistic_sampler(self, response): | |||
| s_type = response.get(STRATEGY_TYPE_STR) | |||
| if s_type == SamplingManager.SamplingStrategyType.PROBABILISTIC: | |||
| if s_type == PROBABILISTIC_SAMPLING_STRATEGY: | |||
There was a problem hiding this comment.
we could also do || s_type == SamplingManager.SamplingStrategyType.PROBABILISTIC
|
Could you describe how you tested this? I was under impression that the test_driver had a test for ensuring the clients read the appropriate sampling policy (but maybe it's only in the internal adaptive sampling version). |
|
Ticket for integration tests: jaegertracing/jaeger#804 |
|
Started all in one which I configured with static sampling strategies. Observed it failing and then with the change, it successfully used the new strategies. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #171
Unfortunately, when we swapped over to using string type for thrift instead of int for the python client, I forgot to swap over for the vanilla samplers.
I'm pretty sure our python clients are internally hooked up to emit logs on failure so I'm not sure why this wasn't reported by anyone. We should create some integration tests that handles this.
Signed-off-by: Won Jun Jang wjang@uber.com