Skip to content
This repository has been archived by the owner on Jul 11, 2022. It is now read-only.

Replace concurrent.futures.Future with tornado.concurrent.Future #155

Merged
merged 3 commits into from
Apr 17, 2018

Conversation

yurishkuro
Copy link
Member

Signed-off-by: Yuri Shkuro ys@uber.com

Yuri Shkuro added 2 commits April 16, 2018 22:38
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
@coveralls
Copy link

coveralls commented Apr 17, 2018

Coverage Status

Coverage decreased (-0.05%) to 95.322% when pulling 6f741a6 on remove-futures-dependendcy into 4200bdb on master.

Signed-off-by: Yuri Shkuro <ys@uber.com>
Copy link
Contributor

@black-adder black-adder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sooo how does this work? 'futures;python_version<"3"' requires a higher version of setuptools but somehow tornado.concurrent.Future doesn't? Are we adding a indirect dependence?

@yurishkuro
Copy link
Member Author

@black-adder concurrent.futures is standard in Py3 and futures is a backport of that into Py2 (that's why we can't depend on it in Py3, that module doesn't even compile w/ Py3 - although it could've)

On the other hand, tornado.concurrent.Future is a separate implementation that exists both in py2 and py3 (it might be just an alias to the official Future in py3).

@yurishkuro yurishkuro merged commit b5d37d7 into master Apr 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants