This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Adding support for opentracing 0.32 #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
============================================
- Coverage 89.53% 89.17% -0.37%
- Complexity 542 543 +1
============================================
Files 68 68
Lines 1949 1958 +9
Branches 251 251
============================================
+ Hits 1745 1746 +1
- Misses 129 135 +6
- Partials 75 77 +2
Continue to review full report at Codecov.
|
dougEfresh
force-pushed
the
opentracing-0.32.0
branch
from
0c5297a
to
260e363
Compare
dougEfresh
force-pushed
the
opentracing-0.32.0
branch
5 times, most recently
from
36324c2
to
4466e82
Compare
dougEfresh
force-pushed
the
opentracing-0.32.0
branch
2 times, most recently
from
7e18dd7
to
1e707cf
Compare
Signed-off-by: Doug Chimento <dchimento@gmail.com>
dougEfresh
force-pushed
the
opentracing-0.32.0
branch
from
1e707cf
to
108a26e
Compare
yurishkuro
suggested changes
Mar 28, 2019
jaeger-core/src/main/java/io/jaegertracing/internal/JaegerSpanContext.java
Outdated
Show resolved
Hide resolved
jaeger-core/src/main/java/io/jaegertracing/internal/JaegerTracer.java
Outdated
Show resolved
Hide resolved
jaeger-core/src/test/java/io/jaegertracing/ConfigurationTest.java
Outdated
Show resolved
Hide resolved
jaeger-core/src/test/java/io/jaegertracing/internal/AdhocHeadersTest.java
Outdated
Show resolved
Hide resolved
jaeger-core/src/test/java/io/jaegertracing/internal/AdhocHeadersTest.java
Outdated
Show resolved
Hide resolved
jaeger-core/src/test/java/io/jaegertracing/internal/propagation/TextMapCodecTest.java
Outdated
Show resolved
Hide resolved
Rename traceIdTextMapCodec -> traceIdAsString Remove checking value type in withTag(Tag<?> tag, T value) Signed-off-by: Doug Chimento <dchimento@gmail.com>
dougEfresh
changed the title
yurishkuro
reviewed
Mar 28, 2019
jaeger-core/src/main/java/io/jaegertracing/internal/JaegerSpan.java
Outdated
Show resolved
Hide resolved
jaeger-zipkin/src/test/java/io/jaegertracing/zipkin/internal/ThriftSpanConverterTest.java
Outdated
Show resolved
Hide resolved
jaeger-zipkin/src/test/java/io/jaegertracing/zipkin/internal/V2SpanConverterTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Doug Chimento <dchimento@gmail.com>
Signed-off-by: Doug Chimento <dchimento@gmail.com>
yurishkuro
reviewed
Mar 28, 2019
There was a problem hiding this comment.
lgtm aside from isFinished. Thanks for the PR!
cc @jpkrohling
jaeger-core/src/main/java/io/jaegertracing/internal/JaegerSpan.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Doug Chimento <dchimento@gmail.com>
yurishkuro
approved these changes
Apr 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for opentracing 0.32
See discussions at:
opentracing/opentracing-java#314
See also jaeger issue #566