Refer to valid sampler type values (doc link)

[sjoerdtalsma]

Which problem is this PR solving?

• Make it easier to find the valid sampler types from the java client README

Short description of the changes

• Link to jaeger documentation on client samling configuration.

[codecov]

Codecov Report

Merging #557 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #557      +/-   ##
============================================
- Coverage     89.74%   89.38%   -0.37%     
+ Complexity      540      537       -3     
============================================
  Files            68       68              
  Lines          1940     1940              
  Branches        249      249              
============================================
- Hits           1741     1734       -7     
- Misses          126      132       +6     
- Partials         73       74       +1

Impacted Files	Coverage Δ	Complexity Δ
...rtracing/internal/reporters/CompositeReporter.java	71.42% <0%> (-28.58%)	6% <0%> (-1%)
...java/io/jaegertracing/zipkin/ZipkinV2Reporter.java	71.42% <0%> (-28.58%)	2% <0%> (-1%)
...gertracing/internal/reporters/LoggingReporter.java	81.81% <0%> (-9.1%)	4% <0%> (-1%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a5110...ce8cb0e. Read the comment docs.

[objectiser]

Good idea, but think it might be better if the hyperlink was just on the words "sampler type".

[sjoerdtalsma]

You're right. Updated the link

[objectiser]

LGTM - can you sign the comment though. Thanks.

[sjoerdtalsma]

@objectiser

LGTM - can you sign the comment though. Thanks.

Sure, want me to just add a "Signed off by" line to the main comment of this PR or must I ammend my commits? (I made the change through the github web UI, so not that comfortable here 😉 )

[objectiser]

@sjoerdtalsma You will need to amend the commit, you could squash and rebase at the same time.

[sjoerdtalsma]

-> Any idea how to do this through github's UI?

The commits are signed by github because I use 2PA I think (see Verified with the commits).
Unfortunately I can't sign locally, as I don't have my PGP keys with me on the computer I'm currently using.

[sjoerdtalsma]

I could re-do the change this evening on my laptop though, so don't spend too much time on this 😉

[sjoerdtalsma]

Rebased, squashed, amended, signed, signed off and force-pushed... 😄

[sjoerdtalsma]

Travis build failed??