Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Add jaeger-client module #479

Merged
merged 1 commit into from
Jul 6, 2018

Conversation

jpkrohling
Copy link
Collaborator

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Which problem is this PR solving?

  • Providing a module for instrumented applications with the tracer resolver and a module with senders, like jaeger-thrift. Having this abstracted under a new module makes it easier to change the sender in the future, or add more dependencies as we need.

Short description of the changes

Before, this was required:

        <dependency>
            <groupId>io.jaegertracing</groupId>
            <artifactId>jaeger-thrift</artifactId>
            <version>0.30.0</version>
        </dependency>
        <dependency>
            <groupId>io.jaegertracing</groupId>
            <artifactId>jaeger-tracerresolver</artifactId>
            <version>0.30.0</version>
        </dependency>

Which results in:

[INFO] +- io.jaegertracing:jaeger-thrift:jar:0.30.0:compile
[INFO] |  \- io.jaegertracing:jaeger-core:jar:0.30.0:compile
[INFO] |     +- io.opentracing:opentracing-api:jar:0.31.0:compile
[INFO] |     +- io.opentracing:opentracing-util:jar:0.31.0:compile
[INFO] |     +- com.google.code.gson:gson:jar:2.8.2:compile
[INFO] |     \- org.slf4j:slf4j-api:jar:1.7.25:compile
[INFO] +- io.jaegertracing:jaeger-tracerresolver:jar:0.30.0:compile
[INFO] |  \- io.opentracing.contrib:opentracing-tracerresolver:jar:0.1.4:compile

Now:

        <dependency>
            <groupId>io.jaegertracing</groupId>
            <artifactId>jaeger-client</artifactId>
            <version>0.30.1-SNAPSHOT</version>
        </dependency>

Which results in:

[INFO] +- io.jaegertracing:jaeger-client:jar:0.30.1-SNAPSHOT:compile
[INFO] |  +- io.jaegertracing:jaeger-thrift:jar:0.30.1-SNAPSHOT:compile
[INFO] |  +- io.jaegertracing:jaeger-tracerresolver:jar:0.30.1-SNAPSHOT:compile
[INFO] |  |  \- io.opentracing.contrib:opentracing-tracerresolver:jar:0.1.4:compile
[INFO] |  \- io.jaegertracing:jaeger-core:jar:0.30.1-SNAPSHOT:compile
[INFO] |     +- io.opentracing:opentracing-api:jar:0.31.0:compile
[INFO] |     +- io.opentracing:opentracing-util:jar:0.31.0:compile
[INFO] |     +- com.google.code.gson:gson:jar:2.8.2:compile
[INFO] |     \- org.slf4j:slf4j-api:jar:1.7.25:compile

@ghost ghost assigned jpkrohling Jul 5, 2018
@ghost ghost added the review label Jul 5, 2018
@jpkrohling
Copy link
Collaborator Author

@objectiser could you please check if this would cover your use case?

@codecov
Copy link

codecov bot commented Jul 5, 2018

Codecov Report

Merging #479 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #479      +/-   ##
============================================
+ Coverage     88.16%   88.18%   +0.01%     
- Complexity      493      495       +2     
============================================
  Files            63       64       +1     
  Lines          1851     1853       +2     
  Branches        241      241              
============================================
+ Hits           1632     1634       +2     
  Misses          141      141              
  Partials         78       78
Impacted Files Coverage Δ Complexity Δ
...n/java/io/jaegertracing/internal/JaegerTracer.java 89.75% <100%> (+0.04%) 24 <1> (+1) ⬆️
...src/main/java/io/jaegertracing/client/Version.java 100% <100%> (ø) 1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e68a097...4253325. Read the comment docs.

@objectiser
Copy link
Contributor

@jpkrohling Could you update the readme to also refer to this module instead of the jaeger-thrift

@jpkrohling
Copy link
Collaborator Author

README updated

@jpkrohling
Copy link
Collaborator Author

To avoid publishing an empty jar (which might not be allowed in some repositories, possibly Sonatype included), @objectiser suggested adding a Version class to the new module, which was done in the last commit.

@jpkrohling jpkrohling force-pushed the Add-Client-Module branch 3 times, most recently from 00302e9 to 5526cbb Compare July 6, 2018 15:46
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling merged commit 4253325 into jaegertracing:master Jul 6, 2018
@ghost ghost removed the review label Jul 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants