This repository has been archived by the owner on May 23, 2024. It is now read-only.
Do not strip leading zeros from trace IDs #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 14, 2019 21:07
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
|
I was afraid of this, crossdock fails with:
need to fix the test driver to perform comparisons based on full length |
Signed-off-by: Yuri Shkuro <ys@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
=========================================
+ Coverage 88.08% 88.1% +0.02%
=========================================
Files 59 59
Lines 3500 3507 +7
=========================================
+ Hits 3083 3090 +7
Misses 305 305
Partials 112 112
Continue to review full report at Codecov.
|
vprithvi
approved these changes
Nov 15, 2019
albertteoh
reviewed
Nov 15, 2019
lukedirtwalker
added a commit
to lukedirtwalker/jaeger-client-go
that referenced
this pull request
Sep 11, 2020
The wire encoding of the TraceID uses zero prefixes (jaegertracing#472). The JaegerUI also uses zero prefixes (since 1.16). So it makes sense that the Stringer of the TraceID also does this. Resolves jaegertracing#532 Signed-off-by: Lukas Vogel <vogel@anapaya.net>
yurishkuro
pushed a commit
that referenced
this pull request
Sep 12, 2020
* TraceID.String prefix with zeroes The wire encoding of the TraceID uses zero prefixes (#472). The JaegerUI also uses zero prefixes (since 1.16). So it makes sense that the Stringer of the TraceID also does this. Resolves #532 Signed-off-by: Lukas Vogel <vogel@anapaya.net> * SpanID.String prefix with zeroes Also test parsing back works. Signed-off-by: Lukas Vogel <vogel@anapaya.net> * fix tests? how do I run this thing locally? Signed-off-by: Lukas Vogel <vogel@anapaya.net> * fix tests! Signed-off-by: Lukas Vogel <vogel@anapaya.net>
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #471