Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jaeger-postgresql to storage plugins list #684

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

robbert229
Copy link
Contributor

@robbert229 robbert229 commented Mar 14, 2024

Which problem is this PR solving?

This PR lists the postgres-jaeger storage plugin that I maintain to the storage plugins list.

Description of the changes

Adds a link to the storage plugin list.

How was this change tested?

It was visually checked.
image

Checklist

Signed-off-by: John Rowley <johnrowleyster@gmail.com>

Signed-off-by: John Rowley <johnrowleyster@gmail.com>
Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for romantic-neumann-1959d7 ready!

Name Link
🔨 Latest commit 63b6bf8
🔍 Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/65f374e667024f00080fe777
😎 Deploy Preview https://deploy-preview-684--romantic-neumann-1959d7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and the plugin, have you considered how this will work with Jaeger v2 with the new collector?

@jkowall jkowall merged commit 4d627e8 into jaegertracing:main Mar 22, 2024
10 checks passed
@robbert229
Copy link
Contributor Author

Good question, as soon as v2 gets to a mature state I plan on making the migration immediately.

@robbert229 robbert229 deleted the reference/jaeger-postgresql branch March 22, 2024 17:05
@yurishkuro
Copy link
Member

@robbert229 is it implemented as a go-plugin or gRPC server? We plan to sunset the go-plugin support and only support remote servers implementing Remote Storage API (which is mostly how go-plugin also works plus some sidecar mechanics). In Jaeger-v2 the gRPC path is already supported (but we also plan to introduce a V2 Storage API that will be batch-based, not single span like V1 API).

@robbert229
Copy link
Contributor Author

robbert229 commented Mar 22, 2024

It's implemented as a gRPC Server.

I will say that the gRPC server experience is significantly better in my opinion than the original plug-in developer experience.

(I am excitedly waiting for the v2 storage api)

@yurishkuro
Copy link
Member

I will say that the gRPC server experience is significantly better in my opinion than the original plug-in developer experience.

this is why we want to sunset the latter :-). jaegertracing/jaeger#4647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants